Return slugs in find methods #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I assume if a "name" is in slug format, that the slug will be the same as the name?! Assumption aside, I don't see any side effects for methods like `findOrCreateFromString` which call these changed functions.
|
The tests are failing for this one, could you take a look? |
|
i get the same fails locally when running the test without any changes. I tried to trigger the tests again here, but seems they were skipped with no diff. |
|
I've fixed the tests on |
Switch to anonymous migration and void return type for up method (spatie#440) Method for reversing migrations (spatie#442) * Method for reversing migrations * Add missing return type declaration wip Update README.md fix tests Fix styling Update CHANGELOG Return slugs in find methods I assume if a "name" is in slug format, that the slug will be the same as the name?! Assumption aside, I don't see any side effects for methods like `findOrCreateFromString` which call these changed functions. Revert changes to test tests :S allow find from string methods to search slug field
|
I've pushed some changes, all tests pass locally. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#437
I assume if a "name" is in slug format, that the slug will be the same as the name?!
Assumption aside, I don't see any side effects for methods like
findOrCreateFromStringwhich call these changed functions.